Ticket #447 (assigned feature request)

Opened 3 years ago

Last modified 12 months ago

Gamma Control (Support RandR 1.2)

Reported by: doh123@… Owned by: jeremyhu@…
Priority: Nice to Have Milestone: 2.8.0
Component: xserver Version: dev (master)
Keywords: Cc:

Description

Just a feature request...

It would be great, now especially with RandR being put in, if Xquartz could control the screens gamma. Some games in X (native or Wine) are kind of dark and have gamma sliders in them, but in Xquartz they don't do anything... because from what I can tell Xquartz has no way to control screen gamma.

This could look weird in rootless mode, so maybe make it optional for rootless, but works in fullscreen modes?

Change History

comment:1 follow-up: ↓ 2 Changed 3 years ago by jeremyhu@…

What are those games calling into to set the gamma? Is it via RandR or some other mechanism?

comment:2 in reply to: ↑ 1 Changed 3 years ago by doh123@…

Replying to jeremyhu@…:

What are those games calling into to set the gamma? Is it via RandR or some other mechanism?

I really wish I knew... how would I find out? I know that the x server in Crossover handles it fine, but they might have work-a-rounds in their Wine source too.. but their Winesource by itself doesn't fix it cuz I've already built that against Xquartz and it was a no go.

I'll see what I can find out.

comment:3 Changed 3 years ago by doh123@…

according to Vitamin on the winehq forums... gamma is controlled with Wine using... VidMode X11 extension (XF86VidModeSetGamma, XF86VidModeSetGammaRamp functions).

comment:4 Changed 3 years ago by jeremyhu@…

Yeah, I don't think we'll be supporting xf86vm ... why don't they use RandR 1.3 to adjust gamma instead?

comment:5 Changed 3 years ago by doh123@…

probably no one has gotten around to it.... its no major deal, just a "would be nice" type of thing... I'm sure eventually they will, so it might be best to add support in Xquartz for RandR gamma, as its more of the future.

comment:6 Changed 12 months ago by jeremyhu@…

  • Status changed from new to assigned
  • Summary changed from Gamma Control to Gamma Control (Support RandR 1.2)
  • Milestone changed from later to 2.8.0

It would be nice to do this soon. We should implement RandR 1.2:

#if RANDR_12_INTERFACE
    RRScreenSetSizeProcPtr rrScreenSetSize;
    RRCrtcSetProcPtr rrCrtcSet;
    RRCrtcSetGammaProcPtr rrCrtcSetGamma;
    RRCrtcGetGammaProcPtr rrCrtcGetGamma;
    RROutputSetPropertyProcPtr rrOutputSetProperty;
    RROutputValidateModeProcPtr rrOutputValidateMode;
    RRModeDestroyProcPtr rrModeDestroy;
#endif
Note: See TracTickets for help on using tickets.